Skip to content

DISCL-296: DesktopStreamer improvements#60

Merged
rdumusc merged 1 commit intoBlueBrain:masterfrom
dnachbaur:master
Nov 13, 2015
Merged

DISCL-296: DesktopStreamer improvements#60
rdumusc merged 1 commit intoBlueBrain:masterfrom
dnachbaur:master

Conversation

@dnachbaur
Copy link
Copy Markdown
Contributor

  • UI file
  • remove selection rectangle
  • editable list of stream hostnames

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#define 20, and what about retina displays?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dunno, I just moved the code. 20 * devicePixelRatio()?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that should do!

@rdumusc
Copy link
Copy Markdown

rdumusc commented Nov 13, 2015

Otherwise +1, code looks fine. Would you mind adding a screenshot of the what the new UI and hostname selection box looks like?

@dnachbaur
Copy link
Copy Markdown
Contributor Author

desktopstreamer layout

@dnachbaur
Copy link
Copy Markdown
Contributor Author

Updated

@rdumusc
Copy link
Copy Markdown

rdumusc commented Nov 13, 2015

Very good! I asked Pawel about the new hostnames for the 2 new displaywalls, but no reply yet. I don't know if you want to wait to include them in this commit, otherwise you can merge and we do a 0.9.1 release next week

@rdumusc
Copy link
Copy Markdown

rdumusc commented Nov 13, 2015

Just in case, the answer is:
bbpav05 -> 5th floor
bbpav06 -> 6th floor

@dnachbaur
Copy link
Copy Markdown
Contributor Author

You should really relax the per-commit-is-release policy :)

- UI file
- remove selection rectangle
- editable list of stream hostnames
@dnachbaur
Copy link
Copy Markdown
Contributor Author

Added the new hosts

@rdumusc
Copy link
Copy Markdown

rdumusc commented Nov 13, 2015

Haha, there is no per-commit-is-release policy :-) I was just thinking we could do everything in one go, that's all!

rdumusc pushed a commit that referenced this pull request Nov 13, 2015
DISCL-296: DesktopStreamer improvements
@rdumusc rdumusc merged commit 20886c4 into BlueBrain:master Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants