Skip to content

DesktopStreamer: Grid-view like layout in apps listview#84

Merged
rdumusc merged 1 commit intoBlueBrain:masterfrom
dnachbaur:master
Apr 1, 2016
Merged

DesktopStreamer: Grid-view like layout in apps listview#84
rdumusc merged 1 commit intoBlueBrain:masterfrom
dnachbaur:master

Conversation

@dnachbaur
Copy link
Copy Markdown
Contributor

@dnachbaur dnachbaur commented Mar 30, 2016

No description provided.

@dnachbaur
Copy link
Copy Markdown
Contributor Author

dnachbaur commented Mar 30, 2016

FYI @eile

eile
eile reviewed Mar 31, 2016
View reviewed changes
apps/DesktopStreamer/MainWindow.cpp Outdated
{ "DisplayWall 6th floor", "bbpav06.epfl.ch" }
};

const QString streamAll = "Stream all apps";
Copy link
Copy Markdown
Contributor

@eile eile Mar 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just "Stream all"?

@eile
Copy link
Copy Markdown
Contributor

eile commented Mar 31, 2016

Looks nice, but my desktop image is too small: (cry)
screen shot 2016-03-31 at 8 47 09

@dnachbaur
Copy link
Copy Markdown
Contributor Author

dnachbaur commented Mar 31, 2016

Hmm, dual-desktop setup I guess? I'll check what's happening there.

@eile
Copy link
Copy Markdown
Contributor

eile commented Mar 31, 2016

Triple. Could be a fu since the main desktop display is not retina, but the builtin display is? For me is a low prio bug if it's working on the builtin display only.

@dnachbaur
Copy link
Copy Markdown
Contributor Author

dnachbaur commented Mar 31, 2016

It only gets the image from the first desktop, but the size is all desktops. If streamed, the right part is black. So no multi-desktop support right now. It's part of #63 already.

@dnachbaur
Copy link
Copy Markdown
Contributor Author

dnachbaur commented Mar 31, 2016

Looks like this now with 1 desktop
screen shot 2016-03-31 at 5 59 07 pm

@eile
Copy link
Copy Markdown
Contributor

eile commented Mar 31, 2016

+1 from me, as implicitly said above.

@dnachbaur dnachbaur force-pushed the master branch 2 times, most recently from 1fd47fd to 9f283ba Compare April 1, 2016 09:12
@dnachbaur dnachbaur changed the title DesktopStreamer: Grid-view like layout in apps listview, added stream all apps/stream none button DesktopStreamer: Grid-view like layout in apps listview Apr 1, 2016
@dnachbaur
Copy link
Copy Markdown
Contributor Author

dnachbaur commented Apr 1, 2016

Next/last iteration
screen shot 2016-04-01 at 11 13 40 am

@rdumusc rdumusc merged commit 33ecc71 into BlueBrain:master Apr 1, 2016
@eile
Copy link
Copy Markdown
Contributor

eile commented Apr 1, 2016

Unselect/Select all is gone?

@rdumusc
Copy link
Copy Markdown

rdumusc commented Apr 1, 2016

Sorry, merged already. @tribal-tec changed the behaviour a bit from the first version of the PR. Both versions work for me. I think this is also OK because there are different ways to select all windows (rectangle selection or cmd-a) and the 'stop streaming' stops all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rdumusc rdumusc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dnachbaur @eile @rdumusc