This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Grow NetSendBuffer_t dynamically when necessary #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unless we're on OpenACC, then we throw an error.
pramodk
approved these changes
Oct 5, 2020
Contributor
Author
|
please retest |
1 similar comment
Contributor
Author
|
please retest |
Contributor
|
retest this please |
JCGoran
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
The `NetSendBuffer_t` struct in coreneuron has been updated to support dynamic resizing of its internal buffers. It offers now the `grow()` function will double the buffers' size. Until now, the `net_send` buffer was allocated statically at intialization and could not be grown. When many `net_send` events are requested before they have been processed, this fixed buffer size has lead to coreneuron either crashing due to buffer overflows (when used with mod2c) or terminating with an error message (when used with nmodl). We can now call the `grow()` function to dynamically enlarge the buffers when we run out of space. NMODL Repo SHA: BlueBrain/nmodl@b4ccdfe
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unless we're on OpenACC, then we throw an error. This uses BlueBrain/CoreNeuron#395