-
Notifications
You must be signed in to change notification settings - Fork 10
Measurement fixes #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Measurement fixes #107
Conversation
|
I assume this is now complete, is it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a fan of code in comments. Could you please remove it if it is not needed any more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we keep it until after the ARC review, in case it's decided to change both the input fit results and the reponse matrix for the generator systematics?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we can always got back in history (git time machine ;) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then we'd encounter a git paradox!
Fixed.
|
This can be merged (but please go through the code changes). In case if there's a strong need to implement categorisation of the systematics in the tables (rate/shape-changing), I can do it now, otherwise can leave it for later when we start fixing cosmetics. |
|
I don't think we need the categorisation now. And either way, I would put that into a new pull request. |
…a) and pt reweighting
A few fixes and improvements in the cross section measurement workflow: