Panic on wasm32-unknown-unknown without js feature#297
Merged
BurntSushi merged 7 commits intoBurntSushi:masterfrom Apr 18, 2025
Merged
Panic on wasm32-unknown-unknown without js feature#297BurntSushi merged 7 commits intoBurntSushi:masterfrom
wasm32-unknown-unknown without js feature#297BurntSushi merged 7 commits intoBurntSushi:masterfrom
Conversation
80ecf78 to
105db4f
Compare
BurntSushi
requested changes
Mar 12, 2025
Owner
BurntSushi
left a comment
There was a problem hiding this comment.
Nice thank you! Just a few nits.
fd805f5 to
20ca701
Compare
Contributor
Author
|
@BurntSushi Hi, could you please take another look at this? |
Co-authored-by: Andrew Gallant <jamslam@gmail.com>
`jiff` can deal with environments which don't provide monotonic time.
00b4e0c to
7942a08
Compare
Owner
|
I pushed a tweak to the language here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested here: #296 (comment)
I quickly put together a hello-world
trunkproject, and calledjiff::Zoned::new()in it, without thejsfeature enabled.The resulting panic
Zoned::nowonwasm32-unknown-unknownwhenjsfeature is not enabled #296 - the issue is about discoverability of thejsfeature, and this PR greatly improves that.