This repository was archived by the owner on Apr 24, 2025. It is now read-only.
Add random ordering for sort command#185
Open
pjsier wants to merge 1 commit intoBurntSushi:masterfrom
Open
Conversation
jqnatividad
added a commit
to dathere/qsv
that referenced
this pull request
Nov 5, 2021
Though this overlaps with the new `scramble` command, it's still useful to adapt this PR. BurntSushi/xsv#185
|
In your merge request you match on We should emit a warning or at least force --random by matching on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds random ordering to sort based on the comments in #181. It looks like the
SeedableRnggeneration could be simplified withseed_from_u64ifrand_coreis updated, but I wanted to check before doing that.I'm pretty new to Rust, so happy to make changes if anything seems off. Thanks for maintaining this!