fix: add graceful UI fallback for system ringtones on iOS#900
Open
vibhutomer wants to merge 1 commit intoCCExtractor:mainfrom
Open
fix: add graceful UI fallback for system ringtones on iOS#900vibhutomer wants to merge 1 commit intoCCExtractor:mainfrom
vibhutomer wants to merge 1 commit intoCCExtractor:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a UX bug where iOS users are presented with a completely blank screen when navigating to the "System Ringtones" tab. Because Apple's iOS sandbox restricts third-party apps from accessing native system notification sounds, the ringtone provider correctly returns an empty list. This PR intercepts that state and provides a graceful UI fallback, vastly improving the UX for iPhone users and maintaining the app's polished feel.
Proposed Changes
GetPlatform.isIOScheck inside_buildSystemRingtonesTab()inringtone_selection_page.dart.Textwidget explaining the platform limitation.themeControllerto ensure perfect contrast and readability in both Light and Dark modes.Fixes #899
Checklist