Skip to content

fix: resolve exponential timer drain in wake-up challenges by adding … #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vibhutomer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve exponential timer drain in wake-up challenges by adding … #902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions lib/app/modules/alarmChallenge/controllers/alarm_challenge_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ class AlarmChallengeController extends GetxController {
AlarmModel alarmRecord = Get.arguments;

final RxDouble progress = 1.0.obs;
int _timerSessionId = 0;

final RxInt shakedCount = 0.obs;
final isShakeOngoing = Status.initialized.obs;
Expand Down Expand Up @@ -204,7 +205,15 @@ class AlarmChallengeController extends GetxController {
const totalIterations = 1500000;
const decrement = 0.000001;

// Capture the current session ID for this specific async loop
final int currentSessionId = _timerSessionId;

for (var i = totalIterations; i > 0; i--) {
// If the global session ID has changed, kill this orphaned loop immediately
if (currentSessionId != _timerSessionId) {
break;
}

if (!isTimerEnabled) {
debugPrint('THIS IS THE BUG');
break;
Expand All @@ -220,10 +229,36 @@ class AlarmChallengeController extends GetxController {
}

restartTimer() {
_timerSessionId++; // Increment ID to kill any existing async loops
progress.value = 1.0; // Reset the progress to its initial value
_startTimer(); // Start a new timer
}

// void _startTimer() async {
// const duration = Duration(seconds: 15);
// const totalIterations = 1500000;
// const decrement = 0.000001;

// for (var i = totalIterations; i > 0; i--) {
// if (!isTimerEnabled) {
// debugPrint('THIS IS THE BUG');
// break;
// }
// if (progress.value <= 0.0) {
// shouldProcessStepCount = false;
// Get.until((route) => route.settings.name == '/alarm-ring');
// break;
// }
// await Future.delayed(duration ~/ i);
// progress.value -= decrement;
// }
// }

// restartTimer() {
// progress.value = 1.0; // Reset the progress to its initial value
// _startTimer(); // Start a new timer
// }

isChallengesComplete() {
if (!Utils.isChallengeEnabled(alarmRecord)) {
isNumMathQuestionsSet = false;
Expand Down