Implement a graceful UI fallback when system ringtones are unavailable on iOS#903
Open
NihalDR wants to merge 1 commit intoCCExtractor:mainfrom
Open
Implement a graceful UI fallback when system ringtones are unavailable on iOS#903NihalDR wants to merge 1 commit intoCCExtractor:mainfrom
NihalDR wants to merge 1 commit intoCCExtractor:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a UI fallback in the ringtone selection flow to avoid presenting the system-ringtone picker on iOS, where system ringtones aren’t available.
Changes:
- Adds an iOS-specific fallback message in the “System Ringtones” tab instead of rendering the system ringtone picker.
- Leaves the Android flow unchanged by continuing to render
SystemRingtonePickeron non-iOS platforms.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+162
to
+166
| // Widget _buildSystemRingtonesTab() { | ||
| // return SystemRingtonePicker( | ||
| // isFullScreen: true, | ||
| // ); | ||
| // } |
Comment on lines
+168
to
186
| if (GetPlatform.isIOS) { | ||
| return Center( | ||
| child: Padding( | ||
| padding: const EdgeInsets.all(32.0), | ||
| child: Text( | ||
| 'System ringtones are currently only supported on Android.\n\nPlease upload a custom ringtone to use this feature.', | ||
| textAlign: TextAlign.center, | ||
| style: TextStyle( | ||
| color: themeController.primaryTextColor.value.withOpacity(0.7), | ||
| fontSize: 16, | ||
| height: 1.5, | ||
| ), | ||
| ), | ||
| ), | ||
| ); | ||
| } | ||
|
|
||
| return SystemRingtonePicker( | ||
| isFullScreen: true, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a UX issue where iOS users see a blank screen when opening the System Ringtones tab. Since iOS sandbox restrictions prevent third-party apps from accessing native system notification sounds, the ringtone provider returns an empty list.
This PR adds a graceful UI fallback that displays a clear message explaining the limitation instead of showing an empty screen.
Changes
Added GetPlatform.isIOS check in _buildSystemRingtonesTab() (ringtone_selection_page.dart)
Replaced empty list state with a centered explanatory Text widget
Styled the fallback message using themeController to support both Light and Dark modes
Checklist:
Tests added or updated
Documentation updated
Code follows project style guidelines
All tests passing