fix: decouple runtime-from-dist image from go-builder stage#118
Merged
CJackHwang merged 1 commit intodevfrom Mar 20, 2026
Merged
fix: decouple runtime-from-dist image from go-builder stage#118CJackHwang merged 1 commit intodevfrom
CJackHwang merged 1 commit intodevfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
CJackHwang
added a commit
that referenced
this pull request
Mar 20, 2026
Merge pull request #118 from CJackHwang/codex/analyze-and-fix-build-failure-for-pr-117 fix: decouple runtime-from-dist image from go-builder stage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
buildxfailed becauseruntime-from-distindirectly depended on thego-builderstage viaCOPY --from=go-builder /etc/ssl/certs/ca-certificates.crt, which forced an unnecessarygo build(with-X ds2api/internal/version.BuildVersion=...) to run and fail during the Docker multi-stage build.Description
Dockerfileruntime-basestage to installca-certificatesviaapt-getinstead of copying them from thego-builderstage, removing the unintended dependency ongo-builderand ensuringdocker buildx --target runtime-from-distdoes not execute the source compile.COPY --from=go-builder /etc/ssl/certs/ca-certificates.crt ...with anapt-get install ca-certificatessequence inDockerfile.Testing
./tests/scripts/check-stage6-manual-smoke.shwhich passed (output:stage6_manual_smoke=PASS)../tests/scripts/check-refactor-line-gate.shwhich passed (output:checked=130 missing=0 over_limit=0)../tests/scripts/run-unit-all.shwhich completed successfully with all tests passing (summary:# pass 41 # fail 0).npm ci --prefix webuiandnpm run build --prefix webuiwhich succeeded, and replayed the multi-platform Go build loop locally usinggo build -ldflags='-X ds2api/internal/version.BuildVersion=...'for the target set, which completed successfully; fulldocker buildxruns could not be executed here because Docker is unavailable, but the stage-coupling root cause has been removed.Codex Task