fix: allow Docker builds without BUILD_VERSION#120
Closed
jacob-sheng wants to merge 1 commit intoCJackHwang:mainfrom
Closed
fix: allow Docker builds without BUILD_VERSION#120jacob-sheng wants to merge 1 commit intoCJackHwang:mainfrom
jacob-sheng wants to merge 1 commit intoCJackHwang:mainfrom
Conversation
|
@jacob-ayang is attempting to deploy a commit to the cjack's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
按作者要求关闭,稍后会以新的分支、中文描述和统一身份重新提交。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go-builderstage soBUILD_VERSIONis optional underset -uVERSION, then empty valueRoot cause
Zeabur builds the repo
Dockerfilewithout passingBUILD_VERSION. The current shell step expands${BUILD_VERSION}before fallback logic runs, so/bin/shexits withparameter not set.Testing
set -uwhenBUILD_VERSIONis unsetBUILD_VERSIONstill wins when providedgit diff --checkdocker buildor Go tests in this environment becausedockerandgoare unavailable