Update platform_specific settings for non-macos#102
Merged
CLARATION merged 2 commits intoCLARATION:mainfrom Jan 28, 2026
Merged
Update platform_specific settings for non-macos#102CLARATION merged 2 commits intoCLARATION:mainfrom
CLARATION merged 2 commits intoCLARATION:mainfrom
Conversation
5 tasks
CLARATION
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change I was able to get the window icon to appear both in the titlebar and in the taskbar
With this change:
Without this change:
The explanation is that Iced doesn't yet seem to support the xdg-toplevel-icon-v1 protocol, so in order to give icons to the window the way to do that for now is to give the app an application_id and make it match with the .desktop file, and since I've seen that in the flatpak .desktop file it calls it "dev.khcrysalis.PlumeImpactor", then I just gave the same name to the application_id and now the icon works both on the titlebar and the taskbar.
I think this should fix #100 at least for the flatpak version where it automatically installs a .desktop file.