Skip to content

Fixed an invalid handle access #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AshleighAdams merged 1 commit into from
May 19, 2025
Merged

Fixed an invalid handle access #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/SharpModMenu/PlayerExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ internal static class PlayerExtensions
{
public static ObserverInfo GetObserverInfo(this CCSPlayerController player)
{
if (player.Pawn.Value is not CBasePlayerPawn pawn)
if (!player.Pawn.IsValid || player.Pawn.Value is not CBasePlayerPawn pawn)
return new() { Mode = ObserverMode.Roaming, Observing = null };

if (pawn.ObserverServices is not CPlayer_ObserverServices observerServices)
Expand Down
1 change: 1 addition & 0 deletions src/SharpModMenu/PlayerMenuState.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ public void Refresh(bool sortPriorities = true)
public void Dispose()
{
DestroyEntities();
MenuActive = false; // force the removal of this menu from the active menus
}

private CPointWorldText? HighlightText { get; set; }
Expand Down
Loading