Prototype support to monitor mrs(3) from libprocstat/procstat.#2519
Open
Prototype support to monitor mrs(3) from libprocstat/procstat.#2519
Conversation
This prototype allows mrs(3) to export internal state / statistics to the kernel via a new ELF auxarg type, which alongside a new sysctl for process monitoring allows the information to be extracted by libprocstat/procstat for monitoring purposes. This prototype contains many limitations including the use of atomics for statistics gathering in mrs(3) that may either be too heavy weight, unnecesary due to the existing global lock in mrs, or possibly both. This also lifts an approach from our c18n monitoring that, while very functional in practice, appeals for generalisation. It's not clear that we are capturing all the information we want from mrs. And in the absence of context from jemalloc/etc about underlying fragmentation, interpreting this data may be challenging. However, it's very useful to get useful insight into mrs behaviour in practice.
rwatson
added
the
temporal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prototype allows
mrs(3)to export internal state / statistics to the kernel via a new ELF auxarg type, which alongside a new sysctl for process monitoring allows the information to be extracted by libprocstat/procstat for monitoring purposes.This prototype contains many limitations including the use of atomics for statistics gathering in
mrs(3)that may either be too heavy weight, unnecessary due to the existing global lock in mrs, or possibly both. This also lifts an approach from our c18n monitoring that, while very functional in practice, appeals for generalisation. It's not clear that we are capturing all the information we want from mrs. And in the absence of context from jemalloc/etc about underlying fragmentation, interpreting this data may be challenging.However, it's very useful to get useful insight into mrs behaviour in practice.