Skip to content

chore: sync upstream PR #6526 - feat(cli): inline CSS sourcemaps in addition to JS sourcemaps#3

Open
riderx wants to merge 3 commits intoplusfrom
sync/upstream-pr-6526
Open

chore: sync upstream PR #6526 - feat(cli): inline CSS sourcemaps in addition to JS sourcemaps#3
riderx wants to merge 3 commits intoplusfrom
sync/upstream-pr-6526

Conversation

@riderx
Copy link
Member

@riderx riderx commented Nov 28, 2025

Upstream PR Sync

This PR syncs changes from an external contributor's PR on the official Capacitor repository.

Original PR

  • PR: #6526
  • Title: feat(cli): inline CSS sourcemaps in addition to JS sourcemaps
  • Author: @terencehonles

Automation

  • CI will run automatically
  • Claude Code will review for security/breaking changes
  • If approved, this PR will be auto-merged

Synced from upstream by Capacitor+ Bot

Summary by CodeRabbit

  • Bug Fixes
    • Sourcemaps inlining now supports CSS files. Previously, only JavaScript files with corresponding sourcemap files were inlined; this update extends the functionality to CSS files as well.

✏️ Tip: You can customize this high-level summary in your review settings.

This change updates the cli copy's `--inline` handling to also inline
the CSS sourcemaps and not just the JS sourcemaps.
@coderabbitai
Copy link

coderabbitai bot commented Nov 28, 2025

Warning

Rate limit exceeded

@riderx has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 6 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 884f0fa and 4800419.

📒 Files selected for processing (1)
  • cli/src/tasks/sourcemaps.ts (1 hunks)

Walkthrough

The sourcemap inlining logic in cli/src/tasks/sourcemaps.ts was extended to process both JavaScript and CSS files with corresponding .map files. Previously the condition only checked .js files; it now also accepts .css files for sourcemap inlining.

Changes

Cohort / File(s) Summary
Sourcemap file type support expansion
cli/src/tasks/sourcemaps.ts
Extended sourcemap inlining condition to accept both .js and .css files with existing .map files, previously only processed .js files

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Minimal scope: single file modification
  • Straightforward logic extension: adding another file type to existing condition
  • Low risk: parallel handling of CSS follows established .js pattern

Poem

🐰 A rabbit hops through CSS and JavaScript lands,
"These sourcemaps," it squeaks, "now join paw-in-hand!
No more just scripts, but stylesheets too,
Inlining them both—oh what a view!"

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: it describes inlining CSS sourcemaps in addition to JS sourcemaps, which directly matches the file-level summary of extending sourcemap inlining to CSS files.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@riderx riderx force-pushed the sync/upstream-pr-6526 branch from 884f0fa to 4800419 Compare November 28, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants