Added js function "readfile".#164
Open
Erhannis wants to merge 1 commit intoCauldronDevelopmentLLC:masterfrom
Open
Added js function "readfile".#164Erhannis wants to merge 1 commit intoCauldronDevelopmentLLC:masterfrom
Erhannis wants to merge 1 commit intoCauldronDevelopmentLLC:masterfrom
Conversation
Member
|
There's a way to read DXF files but not arbitrary files. It should probably be restricted to only read files in the same directory as root TPL file or below. |
1503ff2 to
c2a9c38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was working in CAMotics and wanted to be able to draw text, which (for Opentype.js) involved opening a (font) file. I couldn't find an existing way to open an arbitrary file in TPL, so I added
readfileto the cbang js standard module to read a whole file into an array of bytes. Let me know if there's already a way of opening files that I missed. Also, it might be worth having a discussion about the security implications of permitting javascript code to read arbitrary files without explicit permission from the user.