feat: api and indexer instrumented with metrics#221
feat: api and indexer instrumented with metrics#221dhyaniarun1993 wants to merge 23 commits intomainfrom
Conversation
// fails the other is cancelled
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (11.39%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
=======================================
Coverage ? 30.65%
=======================================
Files ? 140
Lines ? 9246
Branches ? 0
=======================================
Hits ? 2834
Misses ? 6175
Partials ? 237
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request implements comprehensive Prometheus metrics instrumentation across the API server, indexer, relayer, and Canton SDK, including dedicated monitoring endpoints and updated deployment configurations. It also introduces a robust suite of end-to-end tests covering user registration, JSON-RPC facades, and bridge deposit/withdrawal flows. Feedback highlights the need to remove an outdated compile-time guard in the API middleware, address a risky type assertion in the instrumented indexer store to prevent potential panics, and refactor the indexer's monitoring server initialization to ensure architectural consistency across the codebase.
Closes #205