fix: move release-please config out of workflow into config file#336
Merged
wemeetagain merged 1 commit intomasterfrom Mar 16, 2026
Merged
fix: move release-please config out of workflow into config file#336wemeetagain merged 1 commit intomasterfrom
wemeetagain merged 1 commit intomasterfrom
Conversation
The release-please action was passing release-type, monorepo-tags, and changelog-types via the workflow `with:` block. This caused the node-workspace plugin to pick up the root package.json as a releasable component, generating a bogus v6.0.0 release PR for the private monorepo root. Move all configuration into release-please-config.json so it is the single source of truth. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release-please action was passing release-type, monorepo-tags, and changelog-types via the workflow
with:block. This caused the node-workspace plugin to pick up the root package.json as a releasable component, generating a bogus v6.0.0 release PR for the private monorepo root.Move all configuration into release-please-config.json so it is the single source of truth.
Closes #335's root cause