Skip to content

fix: revise onPrevalidationResult metrics#464

Merged
twoeths merged 1 commit intomasterfrom
tuyen/fix_duplicate_metrics
Aug 22, 2023
Merged

fix: revise onPrevalidationResult metrics#464
twoeths merged 1 commit intomasterfrom
tuyen/fix_duplicate_metrics

Conversation

@twoeths
Copy link
Copy Markdown
Contributor

@twoeths twoeths commented Aug 15, 2023

Motivation

Description

  • Name the validation in gossipsub "preValidationResult" to distinguish to the validation result coming from application
  • Also fix meshPeerChurnEventsUnknown metric

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Patch coverage: 4.25% and project coverage change: -0.94% ⚠️

Comparison is base (23bf0ee) 82.30% compared to head (9bce1ff) 81.37%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #464      +/-   ##
==========================================
- Coverage   82.30%   81.37%   -0.94%     
==========================================
  Files          48       48              
  Lines       12039    12173     +134     
  Branches     1286     1285       -1     
==========================================
- Hits         9909     9906       -3     
- Misses       2130     2267     +137     
Files Changed Coverage Δ
src/metrics.ts 16.43% <3.74%> (-2.57%) ⬇️
src/index.ts 69.87% <100.00%> (-0.11%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twoeths twoeths marked this pull request as ready for review August 15, 2023 06:06
@twoeths twoeths requested a review from a team as a code owner August 15, 2023 06:06
@twoeths twoeths merged commit e51f248 into master Aug 22, 2023
@twoeths twoeths deleted the tuyen/fix_duplicate_metrics branch August 22, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants