Draft
Conversation
twoeths
added a commit
to ChainSafe/lodestar
that referenced
this pull request
Dec 1, 2025
**Motivation** - we usually have to uncompress more messages than needed so it's good to track it in DataTransform **Description** - track `compress` and `uncompress` times by topic type - in this instance, this node only subscribe to 8 column subnets but we usually have to uncompress 9 or up to 10/11 DataColumnSidecars per slot, they will likely be duplicated in the end. See also ChainSafe/js-libp2p-gossipsub#536 part of #8629 <img width="1046" height="485" alt="Screenshot 2025-11-28 at 17 02 42" src="https://github.com/user-attachments/assets/df190b29-6681-48de-a04e-cd79ab82858d" /> Co-authored-by: Tuyen Nguyen <twoeths@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
change validateReceivedMessage() implementation to be synchronous:
msgIdFn()synchronous, switch to use@chainsafe/as-sha256for thisCloses #535