Update chainlit data layer with metadata merging#2688
Merged
hayescode merged 2 commits intoChainlit:mainfrom Nov 24, 2025
Merged
Update chainlit data layer with metadata merging#2688hayescode merged 2 commits intoChainlit:mainfrom
hayescode merged 2 commits intoChainlit:mainfrom
Conversation
jfperusse
requested review from
asvishnyakov,
hayescode and
sandangel
as code owners
dosubot
bot
added
size:S
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
hayescode
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the bug where threads would not be shared anymore as soon as we would leave the context of the shared thread (e.g. refresh, or going to a different conversation) because the session metadata would overwrite the entire thread metadata.
Incoming metadata is now merged with the existing one, and if any incoming key has a None value, we remove that key from the merged metadata.
Summary by cubic
Merge incoming thread metadata instead of overwriting, so shared threads stay shared after refresh or when switching conversations. Incoming keys set to None are treated as deletes.
Written for commit 6adf15c. Summary will update automatically on new commits.