Skip to content

Comments

Fix: Fix CI issue introduced in #2640#2711

Merged
hayescode merged 2 commits intomainfrom
fix/header_auth_ci
Dec 4, 2025
Merged

Fix: Fix CI issue introduced in #2640#2711
hayescode merged 2 commits intomainfrom
fix/header_auth_ci

Conversation

@hayescode
Copy link
Contributor

@hayescode hayescode commented Dec 3, 2025

fix issue introduced in #2640

Issue: The Cypress test should have an access_token cookie in /auth/header response was failing in the "after reloading" test suite. This happened because after a page reload, the user is already authenticated via the cookie set during initial login, so the frontend skips calling /auth/header again. The test was waiting for an /auth/header request that never occurs in this scenario.

Fix: Moved the /auth/header cookie verification test out of the shared shouldBeLoggedIn() function so it only runs during initial login. The reload tests now only verify that the user remains logged in (no alert message, "Hello admin" displayed) without expecting /auth/header to be called again.

Also I updated the uv lock file. It has been a while.


Summary by cubic

Fixes the failing Cypress header-auth test in CI by asserting the access_token cookie only on initial login. After reload, tests now confirm the user is still logged in and no longer wait for /auth/header.

Written for commit d72e0ab. Summary will update automatically on new commits.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. auth Pertaining to authentication. labels Dec 3, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@asvishnyakov
Copy link
Member

@hayescode I think you and @fanyak in #2710 is trying to fix the same issue, right?

@hayescode
Copy link
Contributor Author

@asvishnyakov yeah looks like we both tried fixing at the same time. I'd prefer to merge this one if we can, including the upgraded uv lock file.

@hayescode hayescode enabled auto-merge December 4, 2025 11:07
Copy link
Contributor

@sandangel sandangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hayescode hayescode added this pull request to the merge queue Dec 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2025
@hayescode hayescode added this pull request to the merge queue Dec 4, 2025
Merged via the queue into main with commit 85a4f87 Dec 4, 2025
10 checks passed
@hayescode hayescode deleted the fix/header_auth_ci branch December 4, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auth Pertaining to authentication. size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants