Merged
Conversation
Member
|
@hayescode I think you and @fanyak in #2710 is trying to fix the same issue, right? |
Contributor
Author
|
@asvishnyakov yeah looks like we both tried fixing at the same time. I'd prefer to merge this one if we can, including the upgraded uv lock file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix issue introduced in #2640
Issue: The Cypress test should have an access_token cookie in /auth/header response was failing in the "after reloading" test suite. This happened because after a page reload, the user is already authenticated via the cookie set during initial login, so the frontend skips calling /auth/header again. The test was waiting for an /auth/header request that never occurs in this scenario.
Fix: Moved the /auth/header cookie verification test out of the shared shouldBeLoggedIn() function so it only runs during initial login. The reload tests now only verify that the user remains logged in (no alert message, "Hello admin" displayed) without expecting /auth/header to be called again.
Also I updated the uv lock file. It has been a while.
Summary by cubic
Fixes the failing Cypress header-auth test in CI by asserting the access_token cookie only on initial login. After reload, tests now confirm the user is still logged in and no longer wait for /auth/header.
Written for commit d72e0ab. Summary will update automatically on new commits.