Conversation
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (all 1 issue)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="backend/pyproject.toml">
<violation number="1" location="backend/pyproject.toml:51">
P1: This change lowers the minimum version from `>=1.10.0` to `>=1.0.0`, but the PR description states Python 3.14 support was added in version 1.10.0. Lowering the minimum would allow watchfiles versions (1.0.0-1.9.x) that don't support Python 3.14, contradicting the stated goal. The minimum should remain at `>=1.10.0` to ensure Python 3.14 compatibility.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
|
@hayescode I think Cubic has a point here. If we need this for Python 3.14 and it supported starting from 1.1.1, then what's the reason to update it to just 1.0.0. What was the reason behind CI fail? Something else required lower watchfiles version? Can we upgrade it too? |
|
@asvishnyakov resolved |
|
@hayescode But 1.0.0 doesn't support Python 3.14, only 1.1.1 does. So the change is basically useless |
it allows users to upgrade to 3.14 because now the ceiling is 2.0.0 instead of 1.0.0 but OK changed to 1.1.1 |
We can't upgrade to python 3.14 because the
watchfilesdependency was pinned below 1.0.0 and support was added in 1.1.0.This was attempted to be fixed in #2680 but they're unresponsive so this will supersede that PR.