Skip to content

Comments

chore: bump watchfiles#2733

Merged
asvishnyakov merged 4 commits intomainfrom
bump_watchfiles
Dec 22, 2025
Merged

chore: bump watchfiles#2733
asvishnyakov merged 4 commits intomainfrom
bump_watchfiles

Conversation

@hayescode
Copy link
Contributor

@hayescode hayescode commented Dec 19, 2025

We can't upgrade to python 3.14 because the watchfiles dependency was pinned below 1.0.0 and support was added in 1.1.0.

This was attempted to be fixed in #2680 but they're unresponsive so this will supersede that PR.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. backend Pertains to the Python backend. labels Dec 19, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@asvishnyakov asvishnyakov changed the title bump watchfiles chore: bump watchfiles Dec 19, 2025
asvishnyakov
asvishnyakov previously approved these changes Dec 19, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files (changes from recent commits).

Prompt for AI agents (all 1 issue)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="backend/pyproject.toml">

<violation number="1" location="backend/pyproject.toml:51">
P1: This change lowers the minimum version from `&gt;=1.10.0` to `&gt;=1.0.0`, but the PR description states Python 3.14 support was added in version 1.10.0. Lowering the minimum would allow watchfiles versions (1.0.0-1.9.x) that don&#39;t support Python 3.14, contradicting the stated goal. The minimum should remain at `&gt;=1.10.0` to ensure Python 3.14 compatibility.</violation>
</file>

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

@asvishnyakov
Copy link
Member

asvishnyakov commented Dec 19, 2025

@hayescode I think Cubic has a point here. If we need this for Python 3.14 and it supported starting from 1.1.1, then what's the reason to update it to just 1.0.0. What was the reason behind CI fail? Something else required lower watchfiles version? Can we upgrade it too?

@hayescode
Copy link
Contributor Author

@asvishnyakov resolved

@asvishnyakov
Copy link
Member

asvishnyakov commented Dec 19, 2025

@hayescode But 1.0.0 doesn't support Python 3.14, only 1.1.1 does. So the change is basically useless

@hayescode
Copy link
Contributor Author

hayescode commented Dec 19, 2025

@hayescode But 1.0.0 doesn't support Python 3.14, only 1.1.1 does. So the change is basically useless

it allows users to upgrade to 3.14 because now the ceiling is 2.0.0 instead of 1.0.0 but OK changed to 1.1.1

@asvishnyakov asvishnyakov added this pull request to the merge queue Dec 22, 2025
Merged via the queue into main with commit 2aedf18 Dec 22, 2025
9 checks passed
@asvishnyakov asvishnyakov deleted the bump_watchfiles branch December 22, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Pertains to the Python backend. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants