Skip to content

Add Sprint 2 files for UC00199 - Kindergarden Forecasting#1520

Merged
MuzamilRafiq merged 4 commits intomasterfrom
Muzamil_UC00199_Sprint2
Sep 21, 2025
Merged

Add Sprint 2 files for UC00199 - Kindergarden Forecasting#1520
MuzamilRafiq merged 4 commits intomasterfrom
Muzamil_UC00199_Sprint2

Conversation

@MuzamilRafiq
Copy link
Copy Markdown
Contributor

Changes made in this sprint:

➕ Added new visualisations
➖ Removed a few older visualisations
📝 Added insights/explanations for each visualisation
🛠️ Made the notebook compatible with project templates and other requirements
🌐 Generated HTML and JSON files for reporting

Folder location:
Playground/Muzamil/

Copy link
Copy Markdown
Contributor

@pooyafo pooyafo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MuzamilRafiq, your use case is well-done and clearly presented.
You correctly imported the dataset using API and CSV without exposing keys, wrote clean and well-structured code, and followed all naming conventions.
The pull request is in the right folder, the Markdown documentation uses proper Australian English, and the charts and maps have clear legends and labels.
The tutorial is well formatted with step-by-step explanations and meaningful insights, and the correct template was applied.
Overall, it’s a strong, well-organised submission that provides valuable insights.

Copy link
Copy Markdown
Contributor

@jennynguyen2112 jennynguyen2112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Muzamil,

Great work with your use case. Below are some of my comments based on the pull request checklist:

  • Dataset Import: API is used correctly & API Key is not visible. However, for the external dataset that you upload, please change your code to fetch the dataset from the same repository instead of the url.
  • Code Quality & Readability: Code is well-structured. Variable names are logical and easy to follow.
  • Use Case Naming Conventions: Use case naming conventions are followed with the code file.
  • Pull Request Location: Pull request is correctly put in Playground folder
  • Language: no spelling error or incorrect use of language is identified
  • Visualisation: All visualisations have proper legends, labels and interpretations
  • Tutorial quality: You have incorporated introduction before each code snippet to represent each step and provide insights from all visualisations. However, please further elaborate on your instructions of the tutorial, explain further what the code does, especially in the last part where you develop a childcare finder tool - which has a high density of codes without tutorial of what each function does.
  • Use Case Template: Correct template is used in the first part. However, it's still missing a proper conclusion.

Thank you Muzamil!

@MuzamilRafiq
Copy link
Copy Markdown
Contributor Author

Hi @jennynguyen2112 ,

Thanks for your detailed review and feedback 🙏.

  • I’ve added conclusion/summary lines under each Insight section to make the findings clearer.
  • Expanded the Childcare Finder tool instructions so the code functions are easier to follow.
  • Updated the final Conclusion & Next Steps section to reflect the key takeaways from the analysis.
  • Changed dataset loading in the notebook to use the local repo file instead of the GitHub raw URL.

For now, the dataset is still included directly in the repo for testing.
When I next commit in Ready to Publish, I’ll move the dataset into the dependencies folder and update the notebook to pick it from there.

Thanks again for your guidance!

Copy link
Copy Markdown
Contributor

@jennynguyen2112 jennynguyen2112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Muzamil,

Great work with your use case. Below are my comments based on the pull request checklist:

  • Dataset Import: API is used correctly & API Key is not visible
  • Code Quality & Readability: Code is well-structured. Variable names are logical and easy to follow.
  • Use Case Naming Conventions: Use case naming conventions are followed with the code file.
  • Pull Request Location: Pull request is correctly put in Playground folder
  • Language: Correct use of Australian English
  • Visualisation: All visualisations have proper legends, labels and interpretations
  • Tutorial quality: Use case is formatted with clear structure of a tutorial, containing explanation for each code chunk and insights from visualisations
  • Use Case Template: Correct template is used

All good to merge. Thank you!

@MuzamilRafiq MuzamilRafiq merged commit 27ecccc into master Sep 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants