Rename softfork#17799
Merged
Merged
Conversation
…3, but it's activated and its logic has been removed
arvidn
added
the
Changed
AmineKhaldi
approved these changes
Mar 29, 2024
emlowe
approved these changes
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
a recent PR introduced soft-fork 3, to activate message conditions. We've already had a soft-fork 3, and it's activated and removed from the code base.
This PR renames the recent soft-fork to soft-fork 4 to avoid any confusion.
It also removes two disabled tests from the (cancelled and reverted CHIP-13 patch) that refer to soft-fork 4 as the CHIP-13 soft fork.
Current Behavior:
The next soft-fork is called 3.
New Behavior:
The next soft-fork is called 4.
tests
With this change:
That's the changelog mentioning the previous soft-fork 3
Returns no hits