Conversation
Pull Request Test Coverage Report for Build 9096480917Details
💛 - Coveralls |
Rigidity
reviewed
May 10, 2024
4a7deff to
e76160c
Compare
Rigidity
approved these changes
May 20, 2024
Contributor
Rigidity
left a comment
There was a problem hiding this comment.
Looks good to me (feel free to resolve these minor comments)
Contributor
Author
|
these features were cancelled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR is best reviewed one commit at a time.
It implements CHIP-34.
new operators
There are 3 new operators enabled under softfork
1:base64url_encodebase64url_decodekeccak256cost
base64url_encodebase64url_decodekeccak256As always, there's also a cost of 10 per byte that's allocated for the return value.
activation
Since this is a softfork, the extension will only be available when the
ENABLE_BASE64flag is set, which it will be after the softfork activates.The operators will only be available for programs (
<prg>) executing under(softfork <cost> 1 <prg> <arg>)hard fork
There's an option to hard-fork these operators out of the softfork-guard by specifying
ENABLE_BASE64_OPS_OUTSIDE_GUARD.keccak-256
The test vectors are generated using the python wheel
from eth_hash.auto import keccak.