Conversation
Pull Request Test Coverage Report for Build 21491820903Details
💛 - Coveralls |
richardkiss
reviewed
Jan 29, 2026
richardkiss
reviewed
Jan 29, 2026
richardkiss
reviewed
Jan 29, 2026
richardkiss
reviewed
Jan 29, 2026
richardkiss
previously approved these changes
Jan 29, 2026
Contributor
richardkiss
left a comment
There was a problem hiding this comment.
Seems reasonable. I didn't look too closely at whether semantics or costs changed since I know we have a lot of tests for those.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
richardkiss
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main parts of this PR are:
Note
Medium Risk
Touches CLVM operator cost accounting and evaluation order; incorrect cost math or earlier failures could change consensus-critical behavior and reject/accept programs differently.
Overview
Tightens cost accounting across several operators to charge per-argument bytes immediately and fail fast on
max_cost, reducing risk of expensive computation or allocation before cost is enforced. This adjustsconcat/arith/mul/sha cost calculations (includingop_unknown’s concat mode) and addsmax_costenforcement toop_pubkey_for_exp.Adds parameterized stress tests (via
rstest) that build very large atoms and assert expectedCostExceeded/OutOfMemorybehavior across many ops. Separately hardensTreeCachepairserialized_lengthcomputation by using saturating addition to avoid overflow.Written by Cursor Bugbot for commit b4eb8d3. This will update automatically on new commits. Configure here.