Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Pull Request Test Coverage Report for Build 21900906247Details
💛 - Coveralls |
e8937a7 to
203448e
Compare
…s is the more interesting metric when restore_checkpoint() is used
203448e to
b0e8b57
Compare
matt-o-how
reviewed
Feb 11, 2026
matt-o-how
reviewed
Feb 11, 2026
matt-o-how
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiled with the counters feature.
This is the more interesting metric when restore_checkpoint() is used.
Note
Low Risk
Adds new optional (feature-gated) metrics and threads them through the counters output without changing allocation limits or consensus logic; risk is limited to counter correctness and minor overhead when enabled.
Overview
When built with the
countersfeature, the allocator now tracks peak (max) allocated atoms, pairs, and heap bytes over the lifetime of a run (excluding ghost allocations) to better reflect memory pressure even whenrestore_checkpoint()frees allocations.Allocatorupdates these max counters on atom/pair allocations and exposesmax_*getters;run_program_with_counters()now returns these new fields, and tests were extended to assert the max counters are not reduced byrestore_checkpoint().Written by Cursor Bugbot for commit c68373b. This will update automatically on new commits. Configure here.