You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Medium Risk
Broad, cross-cutting API type change touches core interpreter flag plumbing and external bindings; behavior should be equivalent but incorrect flag conversions or combination logic could subtly change execution modes.
Overview
Introduces ClvmFlags (via bitflags) to strongly-type ChiaDialect/Dialect flag handling, replacing ad-hoc u32 bitmask constants and updating all call sites to use contains, union, and empty().
Updates public exports to expose ClvmFlags and MEMPOOL_MODE (now a ClvmFlags value), adds ChiaDialect: Default, and includes a unit test to ensure flag bit values don’t overlap.
Python bindings continue to accept u32 flags but now convert via ClvmFlags::from_bits_truncate, and module-level flag constants are exported as bits() values; benchmarks/fuzz/tools are updated accordingly.
Written by Cursor Bugbot for commit e6c1934. This will update automatically on new commits. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using the bitflags crate.
Note
Medium Risk
Broad, cross-cutting API type change touches core interpreter flag plumbing and external bindings; behavior should be equivalent but incorrect flag conversions or combination logic could subtly change execution modes.
Overview
Introduces
ClvmFlags(viabitflags) to strongly-typeChiaDialect/Dialectflag handling, replacing ad-hocu32bitmask constants and updating all call sites to usecontains,union, andempty().Updates public exports to expose
ClvmFlagsandMEMPOOL_MODE(now aClvmFlagsvalue), addsChiaDialect: Default, and includes a unit test to ensure flag bit values don’t overlap.Python bindings continue to accept
u32flags but now convert viaClvmFlags::from_bits_truncate, and module-level flag constants are exported asbits()values; benchmarks/fuzz/tools are updated accordingly.Written by Cursor Bugbot for commit e6c1934. This will update automatically on new commits. Configure here.