Skip to content

Update minimum macos to 15#726

Merged
arvidn merged 2 commits intomainfrom
EL.macos-update
Mar 4, 2026
Merged

Update minimum macos to 15#726
arvidn merged 2 commits intomainfrom
EL.macos-update

Conversation

@emlowe
Copy link
Copy Markdown
Contributor

@emlowe emlowe commented Mar 2, 2026

Update minimum macOS to 15

Use macos-15 (which is a GH runner) for Apple Silicon builds
Set MACOSX_DEPLOYMENT_TARGET to 15

Note

Cursor Bugbot is generating a summary for commit a55eef8. Configure here.

@emlowe emlowe changed the title Update macos to 15 Update minimum macos to 15 Mar 2, 2026
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Deployment target bump breaks macOS 13/14 compatibility
    • Reverted MACOSX_DEPLOYMENT_TARGET from "15.0" back to "13.0" in both build-m1-wheel.yml and build-test.yml, preserving backward compatibility with macOS 13/14 while keeping the runner update to macOS 15.

Create PR

Or push these changes by commenting:

@cursor push 1790a653a8
Preview (1790a653a8)
diff --git a/.github/workflows/build-m1-wheel.yml b/.github/workflows/build-m1-wheel.yml
--- a/.github/workflows/build-m1-wheel.yml
+++ b/.github/workflows/build-m1-wheel.yml
@@ -46,7 +46,7 @@
 
       - name: Build m1 wheels
         env:
-          MACOSX_DEPLOYMENT_TARGET: "15.0"
+          MACOSX_DEPLOYMENT_TARGET: "13.0"
         run: |
           python3 -m venv venv
           . ./venv/bin/activate

diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml
--- a/.github/workflows/build-test.yml
+++ b/.github/workflows/build-test.yml
@@ -49,7 +49,7 @@
       - name: Build MacOs with maturin on Python ${{ matrix.python }}
         if: startsWith(matrix.os, 'macos')
         env:
-          MACOSX_DEPLOYMENT_TARGET: "15.0"
+          MACOSX_DEPLOYMENT_TARGET: "13.0"
         run: |
           python -m venv venv
           ln -s venv/bin/activate
This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

Comment thread .github/workflows/build-m1-wheel.yml
@coveralls-official
Copy link
Copy Markdown

coveralls-official bot commented Mar 2, 2026

Pull Request Test Coverage Report for Build 22669025130

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.172%

Totals Coverage Status
Change from base Build 22630808145: 0.0%
Covered Lines: 6888
Relevant Lines: 7812

💛 - Coveralls

@arvidn arvidn merged commit 2ca5248 into main Mar 4, 2026
32 checks passed
@arvidn arvidn deleted the EL.macos-update branch March 4, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants