Enhance HTTP resilience by ignoring timeouts for Server-Sent Events#12
Open
Hanskrogh wants to merge 1 commit intoChilliCream:mainfrom
Open
Enhance HTTP resilience by ignoring timeouts for Server-Sent Events#12Hanskrogh wants to merge 1 commit intoChilliCream:mainfrom
Hanskrogh wants to merge 1 commit intoChilliCream:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the resilience and reliability of HTTP client requests in the
AddServiceDefaultsextension, especially for Server-Sent Events (SSE). It introduces custom timeout and retry logic for SSE requests, ensuring they are not interrupted by standard timeout or retry policies. Additionally, it includes some minor code cleanups and formatting improvements.Resilience improvements for HTTP clients:
AddStandardResilienceHandlerto detect Server-Sent Event (SSE) requests and disables both attempt and total request timeouts for them, preventing SSE connections from being prematurely closed.IsServerSentEventRequesthelper method to identify SSE requests by checking for thetext/event-streammedia type in theAcceptheader.