Skip to content

Fix #3736 #3748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisTitusTech merged 1 commit into from
Dec 1, 2025
Merged

Fix #3736 #3748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions functions/private/Invoke-WinUtilTweaks.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ function Invoke-WinUtilTweaks {
$KeepServiceStartup = $true
)

if ($Checkbox -like "*Toggle*") {
$CheckBox = $sync.configs.tweaks.$CheckBox
}

Write-Debug "Tweaks: $($CheckBox)"
Copy link

@QbikEdge QbikEdge Nov 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea it make sense. The only place $CheckBox change would be used is here:

Write-Debug "Tweaks: $($CheckBox)"

and i would argue it makes debug not easier if you change
WPFToggleDarkMode with System.Collections.Hashtable+SyncHashtable.configs.tweaks.WPFToggleDarkMode

Or am i wrong?

because for dark mode toggle is..

  • the value of $CheckBox -> WPFToggleDarkMode
  • the value of $sync.configs.tweaks.$CheckBox -> System.Collections.Hashtable+SyncHashtable.configs.tweaks.WPFToggleDarkMode

Copy link
Contributor Author

@younesaassila younesaassila Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea it make sense. The only place $CheckBox change would be used is here:

Write-Debug "Tweaks: $($CheckBox)"

and i would argue it makes debug not easier if you change

WPFToggleDarkMode with System.Collections.Hashtable+SyncHashtable.configs.tweaks.WPFToggleDarkMode

Or am i wrong?

because for dark mode toggle is..

  • the value of $CheckBox -> WPFToggleDarkMode

  • the value of $sync.configs.tweaks.$CheckBox -> System.Collections.Hashtable+SyncHashtable.configs.tweaks.WPFToggleDarkMode

Yes it makes the debug log more complicated for no good reason

if($undo) {
$Values = @{
Expand Down
Loading