Fix sidebar showing blank when church name not configured#8100
Merged
Fix sidebar showing blank when church name not configured#8100
Conversation
Add 'ChurchCRM' fallback to brand-text span so fresh/demo installs show a meaningful name in the sidebar instead of an empty space. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
DawoudIO
requested review from
DAcodedBEAT,
MrClever,
bigtigerku,
grayeul and
respencer
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a fresh-install UX issue where the sidebar brand text can appear blank when sChurchName is not configured, by adding a default fallback label.
Changes:
- Add a fallback to display
ChurchCRMin the sidebar brand text whenChurchMetaData::getChurchName()is empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a fallback display value to the sidebar brand-text span so that fresh or demo installations show "ChurchCRM" instead of a blank space next to the logo when
sChurchNamehas not yet been configured in System Settings.Changes
src/Include/Header.php: use?: gettext('ChurchCRM')fallback on the brand-text spanWhy
On a fresh install,
SystemConfig::getValue('sChurchName')returns an empty string, leaving the sidebar logo area with no visible name. This is confusing UX — showing "ChurchCRM" as a default makes the sidebar immediately legible until the admin sets their church name.Files Changed
src/Include/Header.php— 1 line changedTesting
🤖 Generated with Claude Code