feat: add /api/map/neighbors/{familyId} endpoint

[DawoudIO]

What changed

• Add GET /api/map/neighbors/{familyId} endpoint using FamilyMiddleware for family lookup and validation
• Pre-filter candidate families with a lat/lng bounding box query before per-record distance calculation in PHP (avoids full table scan)
• Use existing GeoUtils for distance and bearing — drops the undeclared mjaschen/phpgeo dependency (not in composer.json/lock; Spherical Law of Cosines is accurate enough for finding church neighbors)
• Fix OpenAPI annotation: correct path template, familyId as in=path, valid @OA\Get() syntax
• Use renderErrorJSON + gettext() for error responses (consistent with other routes)
• Update agent skill docs: document FamilyMiddleware pattern for routes with familyId

Testing

Ensure demo DB is loaded, then run the Cypress spec or call the endpoint directly:

GET /api/map/neighbors/{familyId}?maxNeighbors=5&maxDistance=50

Cypress spec: cypress/e2e/api/private/map-neighbors.spec.js

[Copilot]

Pull request overview

Adds a new Map API capability to fetch “neighbor” families by distance, leveraging mjaschen/phpgeo (Vincenty) for distance calculation while keeping legacy geodesy helpers as fallback/for display.

Changes:

• Add GET /api/map/neighbors/{familyId} endpoint (with FamilyMiddleware) to return nearby families, distances, bearings, and household members.
• Add a Cypress API spec to validate the new endpoint behavior against seeded demo data.
• Update Slim MVC skill docs to document the FamilyMiddleware pattern for routes with familyId.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.

File	Description
src/api/routes/map.php	Adds the new /map/neighbors/{familyId} endpoint and OpenAPI annotations.
cypress/e2e/api/map-neighbors.spec.js	Adds an API test for the neighbors endpoint using an admin API key.
.agents/skills/churchcrm/slim-mvc-skill.md	Documents using FamilyMiddleware for routes that accept familyId.