Skip to content

Correct design space listing. #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anoto-moniz merged 1 commit into from
Sep 26, 2025
Merged

Correct design space listing. #1001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/citrine/__version__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "3.24.0"
__version__ = "3.24.1"
4 changes: 1 addition & 3 deletions src/citrine/resources/design_space.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,7 @@ def _list_base(self, *, per_page: int = 100, archived: Optional[bool] = None):
if archived is not None:
filters["archived"] = archived

fetcher = partial(self._fetch_page,
fetch_func=partial(self.session.get_resource, version="v4"),
additional_params=filters)
fetcher = partial(self._fetch_page, additional_params=filters, version="v4")
return self._paginator.paginate(page_fetcher=fetcher,
collection_builder=self._build_collection_elements,
per_page=per_page)
Expand Down
6 changes: 3 additions & 3 deletions tests/resources/test_design_space.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ def test_list_design_spaces(valid_formulation_design_space_data, valid_enumerate

# Then
expected_call = FakeCall(method='GET', path='/projects/{}/design-spaces'.format(collection.project_id),
params={'per_page': 20, 'page': 1, 'archived': False})
params={'per_page': 20, 'page': 1, 'archived': False}, version="v4")
assert 1 == session.num_calls, session.calls
assert expected_call == session.calls[0]
assert len(design_spaces) == 2
Expand All @@ -344,7 +344,7 @@ def test_list_all_design_spaces(valid_formulation_design_space_data, valid_enume

# Then
expected_call = FakeCall(method='GET', path='/projects/{}/design-spaces'.format(collection.project_id),
params={'per_page': 25, 'page': 1})
params={'per_page': 25, 'page': 1}, version="v4")
assert 1 == session.num_calls, session.calls
assert expected_call == session.calls[0]
assert len(design_spaces) == 2
Expand All @@ -363,7 +363,7 @@ def test_list_archived_design_spaces(valid_formulation_design_space_data, valid_

# Then
expected_call = FakeCall(method='GET', path='/projects/{}/design-spaces'.format(collection.project_id),
params={'per_page': 25, 'page': 1, 'archived': True})
params={'per_page': 25, 'page': 1, 'archived': True}, version="v4")
assert 1 == session.num_calls, session.calls
assert expected_call == session.calls[0]
assert len(design_spaces) == 2
Expand Down
9 changes: 6 additions & 3 deletions tests/resources/test_predictor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,8 @@ def test_list(valid_graph_predictor_data, valid_graph_predictor_data_empty):
# Then
expected_call = FakeCall(method='GET',
path='/projects/{}/predictors'.format(collection.project_id),
params={'per_page': 25, 'page': 1, 'archived': False})
params={'per_page': 25, 'page': 1, 'archived': False},
version="v4")
assert 1 == session.num_calls, session.calls
assert expected_call == session.calls[0]
assert len(predictors) == 2
Expand All @@ -320,7 +321,8 @@ def test_list_all(valid_graph_predictor_data, valid_graph_predictor_data_empty):
# Then
expected_call = FakeCall(method='GET',
path='/projects/{}/predictors'.format(collection.project_id),
params={'per_page': 25, 'page': 1})
params={'per_page': 25, 'page': 1},
version="v4")
assert 1 == session.num_calls, session.calls
assert expected_call == session.calls[0]
assert len(predictors) == 2
Expand All @@ -339,7 +341,8 @@ def test_list_archived(valid_graph_predictor_data):
assert session.num_calls == 1
assert session.last_call == FakeCall(method='GET',
path=f"/projects/{pc.project_id}/predictors",
params={'per_page': 20, 'page': 1, 'archived': True})
params={'per_page': 20, 'page': 1, 'archived': True},
version="v4")


def test_get(valid_graph_predictor_data):
Expand Down
Loading