Conversation
- Fix copy-paste bug in migrate_deprecated_argument where both sides of the error message showed new_arg_name instead of old_arg_name - Replace bare Exception with TypeError in validate_type for clearer error semantics - Fix NotFound.build() lambda signature (lambda self: -> lambda:) that silently prevented api_error from being populated - Fix "Cant" typo in WorkflowNotReadyException message Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
Consolidated into docs/improve-sdk-documentation branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
migrate_deprecated_argumentwhere error message showednew_arg_nametwice instead ofnew_arg_nameandold_arg_nameExceptionwithTypeErrorinvalidate_typefor clearer error semanticsNotFound.build()lambda signature (lambda self:→lambda:) that silently preventedapi_errorfrom being populatedWorkflowNotReadyExceptionmessage → "Cannot"Test plan
pytest.raises(Exception)which catchesTypeError)🤖 Generated with Claude Code
PR 1 of 11 in the error handling improvement series.