Skip to content

Fix error message bugs#1028

Closed
gjmulhol wants to merge 1 commit intomainfrom
fix/error-message-bugs
Closed

Fix error message bugs#1028
gjmulhol wants to merge 1 commit intomainfrom
fix/error-message-bugs

Conversation

@gjmulhol
Copy link
Copy Markdown

Summary

  • Fix copy-paste bug in migrate_deprecated_argument where error message showed new_arg_name twice instead of new_arg_name and old_arg_name
  • Replace bare Exception with TypeError in validate_type for clearer error semantics
  • Fix NotFound.build() lambda signature (lambda self:lambda:) that silently prevented api_error from being populated
  • Fix "Cant" typo in WorkflowNotReadyException message → "Cannot"

Test plan

  • All 1342 existing tests pass
  • No message format assertions broken (tests use pytest.raises(Exception) which catches TypeError)

🤖 Generated with Claude Code

PR 1 of 11 in the error handling improvement series.

- Fix copy-paste bug in migrate_deprecated_argument where both
  sides of the error message showed new_arg_name instead of
  old_arg_name
- Replace bare Exception with TypeError in validate_type for
  clearer error semantics
- Fix NotFound.build() lambda signature (lambda self: -> lambda:)
  that silently prevented api_error from being populated
- Fix "Cant" typo in WorkflowNotReadyException message

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@gjmulhol
Copy link
Copy Markdown
Author

Consolidated into docs/improve-sdk-documentation branch.

@gjmulhol gjmulhol closed this Mar 25, 2026
@gjmulhol gjmulhol deleted the fix/error-message-bugs branch March 25, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant