Skip to content

Update GEMD version#959

Merged
jspeerless merged 5 commits intomainfrom
update-gemd-version
Aug 5, 2024
Merged

Update GEMD version#959
jspeerless merged 5 commits intomainfrom
update-gemd-version

Conversation

@jspeerless
Copy link
Copy Markdown
Collaborator

@jspeerless jspeerless commented Aug 5, 2024 •
edited
Loading

Citrine Python PR

Description

Update GEMD version to 2.1.8 to allow handling of % and similar units

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

@jspeerless jspeerless requested a review from kroenlein August 5, 2024 17:48
kroenlein
kroenlein approved these changes Aug 5, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@kroenlein kroenlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jspeerless jspeerless merged commit b157748 into main Aug 5, 2024
@jspeerless jspeerless deleted the update-gemd-version branch August 5, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kroenlein kroenlein kroenlein approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jspeerless @kroenlein