Deprecate training_data on subpredictors.#960
Merged
anoto-moniz merged 1 commit intomainfrom Aug 26, 2024
Merged
Conversation
For quite a while, the backend has only supported training data supplied on graph predictors. To support the existing interface where it can be provided on many subpredictors, the backend hoists any training data it finds up to the root. Deprecating the associated fields in the SDK is a step towards no longer needing to do that.
kroenlein
approved these changes
Aug 23, 2024
Collaborator
kroenlein
left a comment
kroenlein
left a comment
There was a problem hiding this comment.
LGTM
Does this have any consequences for e2es?
Collaborator
Author
Nothing major. Just ensuring we don't reference these fields anywhere, and ensuring we only add training data to the graph predictors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For quite a while, the backend has only supported training data supplied on graph predictors. To support the existing interface where it can be provided on many subpredictors, the backend hoists any training data it finds up to the root.
Deprecating the associated fields in the SDK is a step towards no longer needing to do that.
PR Type:
Adherence to team decisions