Skip to content

Add project argument to ingest routes that build tables#969

Merged
kroenlein merged 1 commit intomainfrom
maintain/pne-6219-ingest-table-build
Oct 4, 2024
Merged

Add project argument to ingest routes that build tables#969
kroenlein merged 1 commit intomainfrom
maintain/pne-6219-ingest-table-build

Conversation

@kroenlein
Copy link
Copy Markdown
Collaborator

@kroenlein kroenlein commented Oct 4, 2024

Citrine Python PR

Description

To support the previously functional ingest workflow that included building a table, a project argument has been added to files.ingest and ingest.build_objects.

PNE-6219

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

@kroenlein kroenlein requested a review from a team as a code owner October 4, 2024 00:08
Copy link
Copy Markdown
Contributor

@pacdaemon pacdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kroenlein kroenlein merged commit 2d5352c into main Oct 4, 2024
@kroenlein kroenlein deleted the maintain/pne-6219-ingest-table-build branch October 4, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants