Skip to content

PR suggestions#975

Merged
kroenlein merged 1 commit intobugfix/PNE-816from
origin/bugfix/PNE-816-update
Nov 14, 2024
Merged

PR suggestions#975
kroenlein merged 1 commit intobugfix/PNE-816from
origin/bugfix/PNE-816-update

Conversation

@kroenlein
Copy link
Copy Markdown
Collaborator

Citrine Python PR

Description

Proposed improvements for #974

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

@kroenlein kroenlein requested a review from a team as a code owner November 12, 2024 21:32
@kroenlein kroenlein requested a review from pacdaemon November 12, 2024 21:32
@kroenlein kroenlein merged commit 2efa64d into bugfix/PNE-816 Nov 14, 2024
@kroenlein kroenlein deleted the origin/bugfix/PNE-816-update branch November 14, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant