Skip to content

[PNE-6521] Add attribute accumulation predictor node.#984

Merged
anoto-moniz merged 1 commit intomainfrom
feature/pne-6521-support-AttributeAccumulator
Jan 13, 2025
Merged

[PNE-6521] Add attribute accumulation predictor node.#984
anoto-moniz merged 1 commit intomainfrom
feature/pne-6521-support-AttributeAccumulator

Conversation

@anoto-moniz
Copy link
Copy Markdown
Collaborator

This is a new node used by the backend to propagate attributes through training when we use snapshots.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

This is a new node used by the backend to propagate attributes through
training when we use snapshots.
@anoto-moniz anoto-moniz marked this pull request as ready for review January 13, 2025 21:31
@anoto-moniz anoto-moniz requested a review from a team as a code owner January 13, 2025 21:31
Copy link
Copy Markdown
Collaborator

@kroenlein kroenlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. I thought I'd done this already. LGTM.

@anoto-moniz anoto-moniz merged commit ae8701f into main Jan 13, 2025
@anoto-moniz anoto-moniz deleted the feature/pne-6521-support-AttributeAccumulator branch January 13, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants