Skip to content

PNE-6482 Support default_labels in MaterialSpec constructor#990

Merged
jamie-heller merged 1 commit intomainfrom
task/pne-6482-mat-spec-default-labels
Mar 31, 2025
Merged

PNE-6482 Support default_labels in MaterialSpec constructor#990
jamie-heller merged 1 commit intomainfrom
task/pne-6482-mat-spec-default-labels

Conversation

@jamie-heller
Copy link
Copy Markdown
Contributor

@jamie-heller jamie-heller commented Mar 31, 2025

Support default_labels in MaterialSpec constructor

PNE-6482

Description

This update is analagous to the one in #989

The associated utility function and test have been moved to a shared module, and the documentation has been updated

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

This update is analagous to the one in #989

The associated utility function and test have been moved to a shared module,
and the documentation has been updated
@jamie-heller jamie-heller changed the title DRAFT PNE-6482 Support default_labels in MaterialSpec constructor PNE-6482 Support default_labels in MaterialSpec constructor Mar 31, 2025
@jamie-heller jamie-heller marked this pull request as ready for review March 31, 2025 21:00
@jamie-heller jamie-heller requested a review from a team as a code owner March 31, 2025 21:00
@jamie-heller jamie-heller requested a review from kroenlein March 31, 2025 21:00
Copy link
Copy Markdown
Collaborator

@kroenlein kroenlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming the BE expects the change. Is there any risk of existing artifacts that need to be migrated?

@jamie-heller
Copy link
Copy Markdown
Contributor Author

Looks good, assuming the BE expects the change. Is there any risk of existing artifacts that need to be migrated?

Thanks! I don't that's too much of a concern -- in the non-SDK ingest workflows the MaterialSpecs were already receiving default labels, the SDK support for default labels was only initially added in #989, and the worst case scenario is that a MaterialSpec created via SDK doesn't pick up a default label if no explicit labels are provided.

@jamie-heller jamie-heller merged commit 124ba47 into main Mar 31, 2025
17 checks passed
@jamie-heller jamie-heller deleted the task/pne-6482-mat-spec-default-labels branch March 31, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants