PNE-6482 Support default_labels in MaterialSpec constructor#990
Merged
jamie-heller merged 1 commit intomainfrom Mar 31, 2025
Merged
PNE-6482 Support default_labels in MaterialSpec constructor#990jamie-heller merged 1 commit intomainfrom
default_labels in MaterialSpec constructor#990jamie-heller merged 1 commit intomainfrom
Conversation
This update is analagous to the one in #989 The associated utility function and test have been moved to a shared module, and the documentation has been updated
default_labels in MaterialSpec constructordefault_labels in MaterialSpec constructor
kroenlein
approved these changes
Mar 31, 2025
Collaborator
kroenlein
left a comment
There was a problem hiding this comment.
Looks good, assuming the BE expects the change. Is there any risk of existing artifacts that need to be migrated?
Contributor
Author
Thanks! I don't that's too much of a concern -- in the non-SDK ingest workflows the MaterialSpecs were already receiving default labels, the SDK support for default labels was only initially added in #989, and the worst case scenario is that a MaterialSpec created via SDK doesn't pick up a default label if no explicit labels are provided. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support
default_labelsin MaterialSpec constructorPNE-6482
Description
This update is analagous to the one in #989
The associated utility function and test have been moved to a shared module, and the documentation has been updated
PR Type:
Adherence to team decisions