PNE-6581: Add new criteria. Filling gaps for GEMD query on the SDK.#991
Merged
PNE-6581: Add new criteria. Filling gaps for GEMD query on the SDK.#991
Conversation
pacdaemon
changed the title
kroenlein
reviewed
Apr 17, 2025
Collaborator
kroenlein
left a comment
kroenlein
left a comment
There was a problem hiding this comment.
Did this get validated against live platform responses? It seems to match the API documented in data-objects-openapi-generated.yaml.
Contributor
Author
I dumped the serialized version to verify correctness, But I didn't ran it against an env. Which was a mistake, by making a round trip I detected one issue on serde. The last commit should fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Citrine Python PR
Description
Add Tag and Connectivity Class Filtering to GEMD Queries
Changes
Added TagFilterType enumeration with AND, OR, and NOT operations for tag filtering
Implemented TagsCriteria class for tag-based filtering in GEMD queries
Added ConnectivityClassCriteria class with optional is_consumed and is_produced properties
Added corresponding test factories for new criteria classes
PR Type:
Adherence to team decisions