fix: ID3 TOWN parsing and add regression test#103
Closed
ClementBeal wants to merge 1 commit into
Closed
Conversation
Contributor
|
@ClementBeal you forgot to run dart format . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a small typo with a big impact: when reading the TOWN field (file owner) from MP3 metadata, the code was accidentally comparing values instead of saving the value. So even if the file owner existed in the tag, it was silently ignored.
I also added a test to prevent this from happening again. The test writes a file owner value into an MP3 tag, reads the file back, and checks that the same value is still there. This makes sure the field is now properly handled end to end.