Fixes to mp3 parser and writer#99
Open
lavruh wants to merge 2 commits into
Open
Conversation
…s due to different data length
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MP3 parser now correctly extracts and returns the artist metadata, preventing it from being empty when a valid tag exists.
Corrected a bug in the id3v4_writer that caused corruption or incorrect writing of ID3v4 tags when they contained non-Latin (e.g., Cyrillic, Asian, accented European) symbols.
The root cause was an incorrect calculation of the data length for fields encoded using UTF-8, as the byte length of a UTF-8 character often differs from the character count (unlike Latin-1/ASCII).