Skip to content

Run runtests on GPUs too#1688

Closed
Sbozzolo wants to merge 1 commit intomainfrom
gb/fix_tests_on_gpu
Closed

Run runtests on GPUs too#1688
Sbozzolo wants to merge 1 commit intomainfrom
gb/fix_tests_on_gpu

Conversation

@Sbozzolo
Copy link
Copy Markdown
Member

@Sbozzolo Sbozzolo commented Apr 22, 2024

This job adds a (currently failing) test that checks that we can run runtests.jl on a GPU node.

@Sbozzolo Sbozzolo force-pushed the gb/fix_tests_on_gpu branch 2 times, most recently from 39efb84 to 860f109 Compare April 22, 2024 22:33
@Sbozzolo Sbozzolo changed the title Fix broken tests on GPU Run runtests on GPUs too. Apr 22, 2024
@Sbozzolo Sbozzolo changed the title Run runtests on GPUs too. Run runtests on GPUs too Apr 22, 2024
@charleskawczynski
Copy link
Copy Markdown
Member

Running runtests.jl on buildkite is redundant -- our tests on buildkite basically run everything in runtests.jl in parallel to cut down on CI time. Also, runtests.jl runs many (but not all) tests on buildkite (see #1290 and #1340)

@juliasloan25
Copy link
Copy Markdown
Member

When this PR was opened we only had 2 unit tests running on GPU in buildkite, but now we have 88. Since we individually run each test we want to check on GPU, it would be pretty repetitive to also run all tests on GPU, so I'll close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants