Skip to content

Group/unrolling#2413

Merged
nefrathenrici merged 6 commits intomainfrom
group/unrolling
Jan 26, 2026
Merged

Group/unrolling#2413
nefrathenrici merged 6 commits intomainfrom
group/unrolling

Conversation

@nefrathenrici
Copy link
Copy Markdown
Member

@nefrathenrici nefrathenrici commented Dec 16, 2025 •
edited
Loading

This PR refactors recursive functions to use UnrolledUtilites instead. From the hackathon on 12.12.25

@nefrathenrici nefrathenrici force-pushed the group/unrolling branch 3 times, most recently from 8a86099 to 544366f Compare December 17, 2025 19:19
@nefrathenrici nefrathenrici marked this pull request as ready for review December 17, 2025 19:19
dennisYatunin
dennisYatunin approved these changes Jan 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@dennisYatunin dennisYatunin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! There's definitely a lot of refactoring left to do in these modules, but this is a good start.

You'll probably want to test this with ClimaAtmos before merging it in, just to make sure everything is still type-stable.

Comment thread src/DataLayouts/fused_copyto.jl Outdated
Comment thread src/DataLayouts/has_uniform_datalayouts.jl Outdated
Comment thread src/DataLayouts/fused_copyto.jl Outdated
Comment thread src/DataLayouts/non_extruded_broadcasted.jl Outdated
Comment thread src/DataLayouts/non_extruded_broadcasted.jl Outdated
Comment thread src/Operators/spectralelement.jl Outdated
Comment thread src/Topologies/dss_transform.jl Outdated
Comment thread src/interface.jl Outdated
Comment thread src/interface.jl Outdated
Comment thread src/interface.jl Outdated
@nefrathenrici nefrathenrici force-pushed the group/unrolling branch 2 times, most recently from f5f5ca0 to d89ebe0 Compare January 23, 2026 21:22
@nefrathenrici nefrathenrici enabled auto-merge (squash) January 26, 2026 18:04
@nefrathenrici nefrathenrici merged commit 341c22d into main Jan 26, 2026
36 checks passed
@nefrathenrici nefrathenrici deleted the group/unrolling branch January 26, 2026 19:33
@dennisYatunin dennisYatunin mentioned this pull request Apr 9, 2026
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisYatunin dennisYatunin dennisYatunin approved these changes

@juliasloan25 juliasloan25 Awaiting requested review from juliasloan25

@ph-kev ph-kev Awaiting requested review from ph-kev

@imreddyTeja imreddyTeja Awaiting requested review from imreddyTeja

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nefrathenrici @dennisYatunin @ph-kev @juliasloan25 @imreddyTeja