HA DSN parsing fails with Go 1.26

[M0rdecay]

Code example

With Go 1.25 - HA URL parsed successfully
With Go 1.26 - HA URL parsing fails

Minimalistic example:

package main

import (
	"fmt"
	"net/url"
)

func main() {
	result, err := url.Parse("clickhouse://host1:9440,host2:9440/database")
	fmt.Printf("%#v", result)
	fmt.Printf("%v", err)
}

Affected code - https://github.com/ClickHouse/clickhouse-go/blob/main/clickhouse_options.go#L185

Related issue - golang/go#75859

Related changes in Go src - golang/go@e3be2d1

Details

Environment

• clickhouse-go version: 2.34.0, but the latest one is also affected
• Interface: ClickHouse API / database/sql compatible driver
• Go version: 1.26.0
• Operating system:
• ClickHouse version:
• Is it a ClickHouse Cloud?
• ClickHouse Server non-default settings, if any:
• CREATE TABLE statements for tables involved:
• Sample data for all these tables, use clickhouse-obfuscator if necessary

[M0rdecay]

Maybe forking url.Parse from the previous Go version isn't such a bad idea? I don't think there will be many changes in future. @kavirajk sorry for bothering you, what do you think about this?

I can do it, if you don't mind. It takes less than 600 lines of code (we need to copy some unexported functions and consts).

[kavirajk]

thanks @M0rdecay for starting the discussion.

Looking at how recent changes, they just made special exception only for postgres:// 🤷‍♂️
ScorpiusDraconis83/go@ff654ea

Forking is always an option. I would rather have something like chrurl package (churl.Parse) inside this same repository instead of additional external dependency.

I would discuss with few internal folks as well before going with forking approach. I will keep it posted here

[M0rdecay]

Thank you!

I would rather have something like chrurl package (churl.Parse) inside this same repository instead of additional external dependency

Yeah, that's what i meant

[M0rdecay]

I hope this will be useful - #1787