Fix multi-variable compression stats #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Ah, I just saw you opened an issue about this in #2 ! |
Collaborator
|
SZ3 technically also has the 4D Limitation but already has a builtin workaround for 0-size or 1-size dimensions. I will be adding it to ZFP in any case, so any ZFP-specific hacks should be avoided in this repo. I think the ability of averaging over the ensemble dimension is useful in general, irrespective of the compressor |
Merged
Collaborator
|
I just remembered that we also have a reshape codec, see #4 for an alternative for supporting ZFP |
Member
Author
|
The approach in #4 seems a lot cleaner and avoids the workarounds in the code, so I definitely prefer that alternative! I've removed the special handling of ZFP from the PR now. |
juntyr
changed the title
juntyr
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ZFP and Bitround compressors with the settings from the compression-lab-notebooks. We will probably want to fine-tune the settings at some point to optimize the compression performance but I wanted to get some code working at first.The changes to the code are mostly adjustments that I had to make to get all the compressors working on both the CMIP6 and ERA5 sample data. The two main adjustments I had to do were:
1. ZFP can only compress 1-4D data so we currently manually loop over the ensemble dimension. I am then combining all the (de)compression performance measurements with thecombine_measurementsfunction which is a bit hacky. Is there a better/cleaner way to do it, @juntyr ?2. I adjusted the performance measurements data structure to account for the fact that there might be multiple variables in a given zarr array.