Fix a null reference exception when PlayerExtraOptionsPanel is null

[BlackgamerzVN]

Update GameLobbyBase.cs and fixes null crash when PlayerExtraOptionsPanel is null

[SadPencil]

Ah wait.

                if (PlayerOptionsPanel != null)
                {
                    PlayerExtraOptionsPanel.ForcedNoTeamsAllowChecking = false;
                    PlayerExtraOptionsPanel.ForcedNoTeams = false;

                    PlayerExtraOptionsPanel.UseTeamStartMappingsAllowChecking = false;
                    PlayerExtraOptionsPanel.UseTeamStartMappings = false;
                }

We also have these lines. This probably means if PlayerOptionsPanel != null then PlayerExtraOptionsPanel != null always hold (please check)? And therefore making this PR unnecessary

Edit: these lines was introduced in https://github.com/CnCNet/xna-cncnet-client/pull/719/changes#diff-8288b2a427397578c24040412ece4160f93e250af073d4f376042d8b00c525ceR2390

[Copilot]

Pull request overview

This PR aims to prevent a null-reference crash in GameLobbyBase.ChangeMap when PlayerExtraOptionsPanel is not available while updating map/game-mode–dependent option state.

Changes:

• Adds null guards around PlayerExtraOptionsPanel usage in the non-coop (CoopInfo == null) branch of ChangeMap.
• Changes control flow to return early when PlayerOptionsPanel or PlayerExtraOptionsPanel is null.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The new early return statements can exit ChangeMap after disableGameOptionUpdateBroadcast was set to true (line 2445), which means it never gets reset to false (line 2585) and also skips OnGameOptionChanged(), MapPreviewBox updates, and CopyPlayerDataToUI(). Instead of returning, keep the method flow and only guard the PlayerExtraOptionsPanel property assignments (e.g., wrap them in a null-check / use null-conditional), or ensure disableGameOptionUpdateBroadcast is always reset via try/finally. Also, the PlayerOptionsPanel null-check here is unrelated to the dereference that was crashing (it’s PlayerExtraOptionsPanel).

[SadPencil]

Valid concern. Need to rethink this PR

[github-actions]

Nightly build for this pull request:

• artifacts.zip
  This comment is automatic and is meant to allow guests to get latest automatic builds without registering. It is updated on every successful build.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.